Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add preserves-definedness attributes #717

Merged
merged 4 commits into from
Feb 6, 2025

Conversation

bbyalcinkaya
Copy link
Member

No description provided.

@bbyalcinkaya bbyalcinkaya marked this pull request as ready for review January 29, 2025 16:09
@bbyalcinkaya bbyalcinkaya requested a review from ehildenb January 29, 2025 16:10
@ehildenb
Copy link
Member

Does this result in a performance improvement? If so, how much?

ALos, I think we can perhaps avoid the preserves-definedness with some modifications to the rules? For example, we could have a rule which matches on teh state where the elements do exist in the K cell collection, and rewrite to an error state. Then we have this rule be an owise rule. If that works, do these issues go away, or do we still need preserves-definedness?

@ehildenb
Copy link
Member

ehildenb commented Feb 6, 2025

I checked, and it looks ilke in EVM semantics we also use preservse-definedness attribute for any rules modifying cells in collections, so I guess it makes sense here too!

@automergerpr-permission-manager automergerpr-permission-manager bot merged commit 00f366c into master Feb 6, 2025
6 checks passed
@automergerpr-permission-manager automergerpr-permission-manager bot deleted the definedness-improvements branch February 6, 2025 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants