Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Laravel 11 support #21

Merged
merged 21 commits into from
Mar 18, 2024
Merged

add Laravel 11 support #21

merged 21 commits into from
Mar 18, 2024

Conversation

atmonshi
Copy link
Contributor

No description provided.

@atmonshi
Copy link
Contributor Author

need to do more testing since sanctum updated to v4 and not sure if it will affect the pacakge!
https://laravel.com/docs/master/upgrade#sanctum

@atmonshi atmonshi marked this pull request as draft February 28, 2024 17:57
@rupadana rupadana added the enhancement New feature or request label Feb 29, 2024
@rupadana rupadana added this to the version 3.x milestone Feb 29, 2024
@faizananwerali
Copy link

Laravel 11 has been released. Now waiting for this pull request to get approved.

@faizananwerali
Copy link

I have tested and it is working fine with Laravel 11 and Sanctum.

@atmonshi atmonshi marked this pull request as ready for review March 17, 2024 14:18
@atmonshi
Copy link
Contributor Author

I have tested and it is working fine with Laravel 11 and Sanctum.

prefect, no extra changes required?
I marked this PR ready :)

@faizananwerali
Copy link

I have tested and it is working fine with Laravel 11 and Sanctum.

prefect, no extra changes required? I marked this PR ready :)

Yes no extra changes required

@rupadana
Copy link
Owner

Thank you for your contribution @atmonshi @faizananwerali,

We can merge it after the test pase is successfully passed. There are error while running test, can you please update it?

@atmonshi
Copy link
Contributor Author

all good now, hope I didnt forget anything
if you can run the tests and let see :)

@rupadana
Copy link
Owner

all good now, hope I didnt forget anything if you can run the tests and let see :)

hmmm its like the migration isn't executed

@atmonshi
Copy link
Contributor Author

I dont know what happened there , but I hope this time it will work :)
btw you have access to edit anything in this pr :)

@rupadana rupadana merged commit bea267a into rupadana:main Mar 18, 2024
14 checks passed
@atmonshi atmonshi deleted the laravel-11 branch March 18, 2024 12:35
@rupadana
Copy link
Owner

Finally, its merged. Thank you for your contribution guys @atmonshi @faizananwerali. Appreciate it ☺️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants