Feature tenant aware Refactored #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry i did not see that you wanted to merge into dev branch.
I took some more time to refactor tenancy feature. And added your changes as well. (removed a typo in awereness... etc.)
Now a lot of settings will be retreived from the Resource, like $tenantOwnershipRelationshipName, $tenantRelationshipName and $isScopedToTenant. So some configs are removed. It also looks how the tenancy relation is, for example via a Morph or BelongsTo relation. I haven't tested the Morph relation though.
I now also have used the Handler to filter via the QueryBuilder instead of scoping the Model via the boot method in the model.