Fix cyclical dependencies #935
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthewkmayer
commented
Jan 23, 2018
| @@ -53,7 +53,7 @@ serde_test = "1.0.1" | |||
|
|
|||
| [dev-dependencies.rusoto_dynamodb] | |||
| path = "../services/dynamodb" | |||
| version = "0.30" | |||
| version = ">= 0.30, < 1.0" | |||
There was a problem hiding this comment.
Part one of the magic and one line to actually keep.
matthewkmayer
commented
Jan 23, 2018
rusoto/services/dynamodb/Cargo.toml
Outdated
| @@ -19,7 +19,7 @@ serde_derive = "1.0.2" | |||
| serde_json = "1.0.1" | |||
|
|
|||
| [dependencies.rusoto_core] | |||
| version = "0.31.0" | |||
| version = ">= 0.31" | |||
There was a problem hiding this comment.
Part two of the magic and another line to actually keep.
(Edit: this actually needs to go in service.rs in the service_crategen folder)
|
I've labelled the lines that are relevant to the fix. The other version changes were to demonstrate the fix works: $ cargo publish --dry-run
Updating registry `https://github.com/rust-lang/crates.io-index`
...
Finished dev [unoptimized + debuginfo] target(s) in 66.41 secs
Uploading rusoto_core v0.31.1 (file:///Users/matthew/Documents/rusoto/rusoto/core)
warning: aborting upload due to dry run |
|
#936 is the way to do this. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Demonstrate a fix for #934 .Workaround suggested in rust-lang/cargo#4242 .