V3.1 update

[joshsouza]

This is a work in progress. It relies on the code in russellcardullo/go-pingdom#59 to handle the teams/contacts stuff that has been revamped on Pingdom's side.

I've been testing it out with the examples on a test account and it's worked, with the following tests:

• Creation/deletion from a clean slate
• Updating an existing contact or team
• Reconciling changes made to contacts or teams outside Terraform
• Recreation of contacts/teams deleted outside Terraform

None of the check stuff was touched, and I haven't tested those out explicitly. That said, we've been running off of the earlier version of this PR (before the team/contact stuff) for months, and the check stuff has been working just fine, so I don't expect any work needs to be done there.

[joshsouza]

This will resolve #42

[joshsouza]

@russellcardullo I think this is now ready for your review.
It'll be a breaking change, as the authentication interface has been reworked with the new API token stuff.
My team has been running off of this branch for a while, and while we primarily only utilize checks, it's been operational for us.

[zoltan-patchworks]

@joshsouza is there a way to use it before @russellcardullo merges it and becomes available on Terraform Registry?

[russellcardullo]

LGTM thanks!

[nlamirault]

Great ! thanks @joshsouza

[zoltan-patchworks]

@joshsouza @russellcardullo

What is the new provider syntax?

terraform {
  required_providers {
    pingdom = {
      source  = "russellcardullo/pingdom"
      version = "1.1.3"
    }
  }

  required_version = ">= 0.13"
}


provider "pingdom" {
  pingdom_api_token = "..."
}

terraform plan gives me the following error:

Error: Unsupported argument

  on main.tf line 47, in provider "pingdom":
  47:   pingdom_api_token = "..."

An argument named "pingdom_api_token" is not expected here.

[zoltan-patchworks]

@russellcardullo do you want me to open a separate issue for that?

[joshsouza]

@zoltan-patchworks

terraform {
  required_providers {
    pingdom = {
      source  = "russellcardullo/pingdom"
      version = "1.1.3"
    }
  }

  required_version = ">= 0.13"
}


provider "pingdom" {
  api_token = "..."
}

That should do it for ya

[zoltan-patchworks]

Thanks, it worked.

[zoltan-patchworks]

Fixed, and opened a PR. #80