Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: update the recommended placeholder #53

Merged
merged 3 commits into from
Dec 21, 2024

Conversation

xxchan
Copy link
Contributor

@xxchan xxchan commented Dec 19, 2024

Currently recommended expect![[]] is broken #37, and #38 is blocked for long time, so maybe we can update the recommendation to a safer option instead.

Currently recommended `expect![[]]` is broken rust-analyzer#37, and rust-analyzer#38 is blocked for long time, so maybe we can update the recommendation to a safer option instead.

Signed-off-by: xxchan <xxchan22f@gmail.com>
Signed-off-by: xxchan <xxchan22f@gmail.com>
@xxchan
Copy link
Contributor Author

xxchan commented Dec 19, 2024

@quad if you don't have time looking #38, maybe we can get this merged instead.

Comment on lines +1 to +4
# 1.5.1

* Documentation improvements

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hope you don't mind releasing a new version to bring the doc on docs.us updated

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't at all!

Signed-off-by: xxchan <xxchan22f@gmail.com>
@quad quad added this pull request to the merge queue Dec 21, 2024
Merged via the queue into rust-analyzer:master with commit 9e616f9 Dec 21, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants