feat: Add diagnostic with fix to replace trailing return <val>; with <val>
#16460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
davidsemakula
changed the title
return <val>; with just <val>return <val>; with<val>
davidsemakula
changed the title
return <val>; with<val>return <val>; with <val>
Veykril
reviewed
Jan 31, 2024
davidsemakula
force-pushed
the
trailing-return-diagnostic
branch
from
7cc6b86
to
8c63a32
Compare
Veykril
approved these changes
Feb 8, 2024
|
Thanks, needs a rebase! |
|
✌️ @davidsemakula, you can now approve this pull request! If @Veykril told you to " |
davidsemakula
force-pushed
the
trailing-return-diagnostic
branch
from
8c63a32
to
602acfc
Compare
|
☀️ Test successful - checks-actions |
This was referenced May 9, 2024
This was referenced May 28, 2024
This was referenced Jun 2, 2024
This was referenced Jun 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Works for functions and closures.
Ignores desugared return expressions (e.g. from desugared try operators).
Fixes: #10970
Completes: #11020