feat: Add a diagnostic with a fix to remove return at the end of functions
#11020
Conversation
| @@ -141,6 +145,30 @@ impl ExprValidator { | |||
| }); | |||
| } | |||
|
|
|||
| fn check_for_trailing_return(&mut self, db: &dyn HirDatabase) { | |||
| // todo: handle inner functions and lambdas. | |||
There was a problem hiding this comment.
Inner functions I believe should already be covered by this as they are their own DefWithBodyId again.
For lambdas you will just have to go iterate through all expressions of the body and search for a lambda expression, then do the logic you already do here for it's body expression again
|
|
||
| #[test] | ||
| fn remove_trailing_return() { | ||
| // fixme: this should include the semi. |
There was a problem hiding this comment.
Hmm ye, this one is tricky as diagnostics_display_range doesn't really offer you a nice way to go to the parent as is for checking the semi, leaving the FIXME here for the time being is fine I think, since its not a severe problem.
|
The name seems fine to me, though we could also give with clippy's name choice here which is |
|
Note to maintainers: still working on this, but I'm kinda stalled for the moment, major life event happened (not a bad one) and I haven't been able to get back to this yet (don't have wifi rn, typing this from my phone, my computer isn't even so much as plugged in) |
|
I'll close this for now, if you get back to this feel free to either re-open the PR or open a new one. |
#10970, probably not closes, because of all the fixmes. But I feel comfortable at least asking for review.
Should I have marked the diagnostic as experimental?
I feel like this should be named along the lines of
unwrap expressionbut I can't think of a good name there