Make pub_keypool_oldest optional #216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Issue Currently, get_wallet_info() fails when used with descriptor wallets. * Cause Bitcoin Core's getwalletinfo command produces a result which sometimes includes a field called "keypoololdest". Currently, default wallets have the key but descriptor wallets do not. * Solution Making keypool_oldest optional allows this create to produce the correct results when operating with descriptor wallets.
|
tACK 7a665aa I checked against a regtest node locally and can confirm this issue is as described. I also confirm that the PR solves the issue. |
dunxen
approved these changes
Jun 2, 2022
There was a problem hiding this comment.
ACK 7a665aa
This is currently blocking bwt-dev/bwt#98 when using 23.0+.
tcharding
approved these changes
Aug 17, 2022
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Currently, get_wallet_info() fails when used with descriptor wallets.
Cause
Bitcoin Core's getwalletinfo command produces a result which sometimes
includes a field called "keypoololdest".
Currently, default wallets have the key but descriptor wallets do not.
Solution
Making keypool_oldest optional allows this crate to produce the correct
results when operating with descriptor wallets.