add getzmqnotifications rpc #295
Conversation
|
Is this call new? I can't find it here https://developer.bitcoin.org/search.html?q=getzmqnotifications. Could you also add an entry to the integration test? So that we can see for which versions of core it works. |
|
it was added in 0.17 (changelog), it is the last command in the help page ( |
|
Ah it might be one of the hidden RPCs that are meant for developers. Adding the test should be enough :) |
|
this test now will only check if bitcoind returns an empty array because no zmq subscribers are configured in the test. it will check if the rpc is available but not if the struct gets successfully deserialized can change this later today |
antonilol
force-pushed
the
getzmqnotifications
branch
from
702a074 to
c219c61
Compare
|
can this be reviewed/merged? i will rebase in a second |
antonilol
force-pushed
the
getzmqnotifications
branch
2 times, most recently
from
8d99fbd to
d4983f5
Compare
|
i am still interested in this change, can this be reviewed/merged? |
|
@apoelstra can you take a look at this please, and ack/merge? |
|
Code Review ACK d4983f5 |
antonilol
force-pushed
the
getzmqnotifications
branch
2 times, most recently
from
0088e71 to
89945c1
Compare
antonilol
force-pushed
the
getzmqnotifications
branch
from
89945c1 to
a9be191
Compare
|
the ci will fail on a dependency that doesnt compile anymore on 1.48 (3+ years old), i dont think this is related to this pr because i did not change any dependencies, it did not fail on the tests ran on master 5 months ago so i assume dependencies updated in the mean time and use functions stabilized after 1.48 the ci runs on my fork (antonilol#1) because it will not auto run here |
|
Will go ahead and merge. On master we need to pin some more deps (or even include a lockfile for CI, ideally) and also there are a bunch of clippy warnings here. |
|
Actually @tcharding can you re-ACK first? |
this rpc gives information about the active zmq publishers of bitcoin core
currently
get_zmq_notificationsreturns a Vec directly from bitcoind, but a structure like getindexinfo could also be used because the possible values of the "type" field are known