Replace Signature with Message Signature #326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: mplsgrant <58152638+mplsgrant@users.noreply.github.com>
tcharding
approved these changes
Apr 30, 2024
|
Legendary, thanks! |
tcharding
added a commit
to tcharding/rust-bitcoincore-rpc
that referenced
this pull request
May 1, 2024
In rust-bitcoin#326 we changed a function to use `bitcoin::sign_message::MessageSignature` but doing so requires the "base64" feature to be on for `bitcoin`. This did not get caught by CI but improvements to CI in rust-bitcoin#338 will now catch this. Add a feature to `json` and `client` that allows enabling "base64" if the `verifymessage` RPC call is required.
tcharding
added a commit
to tcharding/rust-bitcoincore-rpc
that referenced
this pull request
May 1, 2024
In rust-bitcoin#326 we changed a function to use `bitcoin::sign_message::MessageSignature` but doing so requires the "base64" feature to be on for `bitcoin`. This did not get caught by CI but improvements to CI in rust-bitcoin#338 will now catch this. Add a feature to `json` and `client` that allows enabling "base64" if the `verifymessage` RPC call is required.
tcharding
added a commit
to tcharding/rust-bitcoincore-rpc
that referenced
this pull request
May 1, 2024
In rust-bitcoin#326 we changed a function to use `bitcoin::sign_message::MessageSignature` but doing so requires the "base64" feature to be on for `bitcoin`. This did not get caught by CI but improvements to CI in rust-bitcoin#338 will now catch this. Add a feature to `json` and `client` that allows enabling "base64" if the `verifymessage` RPC call is required.
tcharding
added a commit
to tcharding/rust-bitcoincore-rpc
that referenced
this pull request
May 1, 2024
In rust-bitcoin#326 we changed a function to use `bitcoin::sign_message::MessageSignature` but doing so requires the "base64" feature to be on for `bitcoin`. This did not get caught by CI but improvements to CI in rust-bitcoin#338 will now catch this. Add a feature to `json` and `client` that allows enabling "base64" if the `verifymessage` RPC call is required.
tcharding
added a commit
to tcharding/rust-bitcoincore-rpc
that referenced
this pull request
May 1, 2024
In rust-bitcoin#326 we changed a function to use `bitcoin::sign_message::MessageSignature` but doing so requires the "base64" feature to be on for `bitcoin`. This did not get caught by CI but improvements to CI in rust-bitcoin#338 will now catch this. Add a feature to `json` and `client` that allows enabling "base64" if the `verifymessage` RPC call is required.
tcharding
added a commit
to tcharding/rust-bitcoincore-rpc
that referenced
this pull request
May 1, 2024
In rust-bitcoin#326 we changed a function to use `bitcoin::sign_message::MessageSignature` but doing so requires the "base64" feature to be on for `bitcoin`. This did not get caught by CI but improvements to CI in rust-bitcoin#338 will now catch this. Add a feature to `json` and `client` that allows enabling "base64" if the `verifymessage` RPC call is required.
Closed
tcharding
added a commit
to tcharding/rust-bitcoincore-rpc
that referenced
this pull request
May 2, 2024
In rust-bitcoin#326 we changed a function to use `bitcoin::sign_message::MessageSignature` but doing so requires the "base64" feature to be on for `bitcoin`. This did not get caught by CI but improvements to CI in rust-bitcoin#338 will now catch this. Add a feature to `json` and `client` that allows enabling "base64" if the `verifymessage` RPC call is required.
tcharding
added a commit
to tcharding/rust-bitcoincore-rpc
that referenced
this pull request
May 4, 2024
tcharding
added a commit
that referenced
this pull request
May 5, 2024
0b08150 Revert "Merge #326: Replace Signature with Message Signature" (Tobin C. Harding) Pull request description: …e with Message Signature" This reverts commit 05f5b82, reversing changes made to c0fc7cb. #326 was broken, I should never have merged it. It also should never have gotten past CI. All blame falls on me. ACKs for top commit: apoelstra: ACK 0b08150 Tree-SHA512: d42c6e1c0e21fd6394d295279d13bdc9a3e34e04df13dc2907336f64f68e111cbf80454d25997382a81ceb6da5a8ca6b9fd28f2a489b3a33c9b5e4f68494e827
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When attempting to use verify_message() function, using Singature kept leading to InvalidSignature.
As such, we replaced Signature with MessageSignature from bitcoin::sign_message::MessageSignature.
We also noticed that there was a // TODO comment to test verify_message, so we also added a test function and it works with the new MessageSignature.