CI: Pin cc for MSRV build #678
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `cc` dependency just stopped working for MSRV build with error
error: package `cc v1.0.96` cannot be built because it requires
rustc 1.63 or newer, while the currently active rustc version is
1.56.1
Pin `cc` back to an earlier version for MSRV build.
This was referenced Apr 30, 2024
|
Thanks for being on top of this! And the new cargo error messages are nice. It's clear that it's a deliberate decision by upstream and it's clear what the issue is. |
apoelstra
approved these changes
May 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
ccdependency just stopped working for MSRV build with errorPin
ccback to an earlier version for MSRV build.