This repository has been archived by the owner on Nov 20, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 14
fix: skip test cases failing in geth #22
Merged
sorpaas
merged 1 commit into
rust-blockchain:master
from
vimpunk:fix/ignore-geth-failing-tests
May 15, 2023
Merged
fix: skip test cases failing in geth #22
sorpaas
merged 1 commit into
rust-blockchain:master
from
vimpunk:fix/ignore-geth-failing-tests
May 15, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All active tests passing, when ran against sputnikvm with above 2 PRs included.
|
sorpaas
approved these changes
May 15, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds filtering logic to
jsontests/tests/state.rs
to skip individual test cases (rather than entire test directories), which is used to skip cases that are failing both in geth and here. These can't currently be fixed until we have a correct reference implementation. These cases are:Further, another test case is skipped due to different implementation details of the test suite (see code comments):
This PR along with rust-ethereum/evm#162 and rust-ethereum/evm#163 brings sputnikvm and the testsuite to parity with geth.