Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes #31 #36

Merged
merged 2 commits into from
May 10, 2018
Merged

fixes #31 #36

merged 2 commits into from
May 10, 2018

Conversation

booyaa
Copy link
Collaborator

@booyaa booyaa commented May 10, 2018

No description provided.

Copy link
Collaborator

@skade skade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, with one nit!

CONTRIBUTING.md Outdated

Label(s): [![focus_topic](https://img.shields.io/badge/-focus_topic-efd6a7.svg)][link_focus_topic]
If you don't write code, that's fine, seek out the tasks labelled [![no_code](https://img.shields.io/badge/-no%20code-fbca04.svg)][link_no_code].
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this could be phrased without focusing on the lack of a skill that much. For example: "non-code contributions are very important to us, you can find tasks here..."

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, that's a much better way to explain the no code label!

@booyaa
Copy link
Collaborator Author

booyaa commented May 10, 2018

I've rewritten the no code section.

@booyaa booyaa merged commit 6c219e3 into rust-community:master May 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants