Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix zig: unsupported exported_symbols_list #171

Merged
merged 2 commits into from
Sep 10, 2023
Merged

fix zig: unsupported exported_symbols_list #171

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7b5eda1
fix zig: unsupported exported_symbols_list
Sep 10, 2023
83a4afc
fix zig: move check to macos
Sep 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
9 changes: 8 additions & 1 deletion src/zig.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,7 @@ impl Zig {
// https://github.com/rust-lang/rust/blob/f0bc76ac41a0a832c9ee621e31aaf1f515d3d6a5/compiler/rustc_target/src/spec/windows_gnu_base.rs#L23
// https://github.com/rust-lang/rust/blob/2fb0e8d162a021f8a795fb603f5d8c0017855160/compiler/rustc_target/src/spec/windows_gnu_base.rs#L22
// https://github.com/rust-lang/rust/blob/f0bc76ac41a0a832c9ee621e31aaf1f515d3d6a5/compiler/rustc_target/src/spec/i686_pc_windows_gnu.rs#L16
// zig doesn't support --disable-auto-image-base, --dynamicbase, and --large-address-aware
// zig doesn't support --disable-auto-image-base, --dynamicbase and --large-address-aware
return None;
}
} else if arg == "-Wl,--no-undefined-version" {
Expand Down Expand Up @@ -168,6 +168,13 @@ impl Zig {
}
}
}
if is_macos {
if arg.starts_with("-Wl,--exported_symbols_list,") {
// zig doesn't support --exported_symbols_list arg
// https://clang.llvm.org/docs/ClangCommandLineReference.html#cmdoption-clang-exported_symbols_list
return None;
}
}
Some(arg.to_string())
};
let has_undefined_dynamic_lookup = |args: &[String]| {
Expand Down