Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixup book CI #205

Merged
merged 1 commit into from
Aug 27, 2019
Merged

Fixup book CI #205

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions ci/install.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,11 +4,10 @@ main() {
local tag=$(git ls-remote --tags --refs --exit-code \
https://github.com/rust-lang-nursery/mdbook \
| cut -d/ -f3 \
| grep -E '^v[0.1.0-9.]+$' \
| grep -E '^v[0-9\.]+$' \
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, this regex didn't work as I assume it was meant to.

If we'd like to constrain to a major version, we should replace this with:

grep -E '^v0.3.[0-9]+$'

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, this implicitly takes us from 0.2.x to 0.3.x. We may want to see if this has negative implications. @steveklabnik this may need to introduce a third version to the upstream book version hack.

| sort --version-sort \
| tail -n1)
# Temporarily use older version until packages are available for 0.2.2 (or newer)
local tag="v0.2.1"

curl -LSfs https://japaric.github.io/trust/install.sh | \
sh -s -- --git rust-lang-nursery/mdbook --tag $tag

Expand Down