This repository has been archived by the owner on Jan 24, 2022. It is now read-only.
drop the /DISCARD/ section #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TL;DR thanks to rust-lang/rust#45031 we no longer need this Now with -C panic=abort all functions are marked with the `nouwind` attribute in LLVM-IR. With this change LLVM won't generate undefined references to `__aeabi_unwind_cpp_pr0` et al. which we don't use / supply but are required by the AEABI standard in the case that a function that throw exceptions exists (semantically, we never have any of those function with panic=abort but the LLVM-IR didn't reflect this before).
|
I think enough time has passed by now so let's merge this. (It's not like I totally forgot about this PR 😅) |
rukai
pushed a commit
to rukai/cortex-m-rt
that referenced
this pull request
May 1, 2021
41: Bumped linked_list_allocator and added `const_mut_refs` feature r=jonas-schievink a=Spadi0 Fixes rust-embedded#40 Co-authored-by: Sam Jones <email@spad.io>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR thanks to rust-lang/rust#45031 we no longer need this
Now with -C panic=abort all functions are marked with the
nouwindattribute inLLVM-IR. With this change LLVM won't generate undefined references to
__aeabi_unwind_cpp_pr0et al. which we don't use / supply but are required bythe AEABI standard in the case that a function that throw exceptions
exists (semantically, we never have any of those function with panic=abort but
the LLVM-IR didn't reflect this before).
the downside of this change is that users will need a recent-ish (1 week old or
newer) nightly or will run into linker errors.
So I'll wait a bit before merging this, I think.