Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cortex-m: fix typos #549

Merged
merged 3 commits into from
Aug 13, 2024
Merged

cortex-m: fix typos #549

merged 3 commits into from
Aug 13, 2024

Conversation

elfenlaid
Copy link
Contributor

@elfenlaid elfenlaid commented Aug 12, 2024

Fix a small typo in the external symbols comment.

Please don't hesitate to close it if it's too bothersome to merge 🙇

UPD: I'm not sure why clippy isn't happy, it seems that 750f5e4 should fix indentation warnings

@elfenlaid elfenlaid requested a review from a team as a code owner August 12, 2024 18:49
@adamgreig
Copy link
Member

Thanks for the typo fix! Not sure what's up with clippy, let's see...

@adamgreig
Copy link
Member

It seems like GHA is getting totally confused and running the clippy check against the wrong commit, great.

adamgreig
adamgreig previously approved these changes Aug 13, 2024
elfenlaid and others added 3 commits August 13, 2024 02:28
@adamgreig adamgreig added this pull request to the merge queue Aug 13, 2024
Merged via the queue into rust-embedded:master with commit b0d2e45 Aug 13, 2024
13 checks passed
@elfenlaid
Copy link
Contributor Author

It seems like GHA is getting totally confused and running the clippy check against the wrong commit, great.

Oh I see. Thank you for figuring it out.

And thank you for figuring out the testsuite configs 🙇

@elfenlaid elfenlaid deleted the patch-1 branch August 13, 2024 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants