Remove #[deny(warnings)] #17

dbrgn · 2019-05-14T19:41:52Z

The library currently does not currently build anymore, because upstream libraries have added new deprecation warnings. A deprecation warning should not break compilation though. There was a post on Reddit about this about a year ago, but I can't find it anymore.

I think adding a CI check step would be fine, but #[deny(warnings)] is a bit too much.

These are the warnings:

warning: use of deprecated item 'hal::digital::OutputPin': Deprecated because the methods cannot return errors. Users should use the traits in digital::v2.
   --> src/lib.rs:111:6                                                       
    |                                                                         
111 | impl hal::digital::OutputPin for Pin {                                  
    |      ^^^^^^^^^^^^^^^^^^^^^^^                                            
    |                                                                         
    = note: #[warn(deprecated)] on by default                                 
                                                                              
warning: use of deprecated item 'hal::digital::InputPin': Deprecated because the methods cannot return errors. Users should use the traits in digital::v2.
   --> src/lib.rs:121:6                                                       
    |                                                                         
121 | impl hal::digital::InputPin for Pin {                                   
    |      ^^^^^^^^^^^^^^^^^^^^^^                                             
                                                                              
warning: use of deprecated item 'hal::digital::InputPin::is_high': Deprecated because the methods cannot return errors. Users should use the traits in digital::v2.
   --> src/lib.rs:131:15                                                      
    |                                                                         
131 |         !self.is_high()                                                 
    |               ^^^^^^^

The library currently does not currently build anymore, because upstream libraries have added new deprecation warnings. A deprecation warning should not break compilation though.

rust-highfive · 2019-05-14T19:41:55Z

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nastevens (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

therealprof · 2019-05-14T19:55:30Z

That's actually an anti-pattern: https://github.com/rust-unofficial/patterns/blob/master/anti_patterns/deny-warnings.md

therealprof

LGTM

hannobraun · 2019-05-16T06:09:42Z

bors r=therealprof

bors · 2019-05-16T06:09:43Z

🔒 Permission denied

Existing reviewers: click here to make hannobraun a reviewer

hannobraun · 2019-05-16T06:46:05Z

Permission denied

Ah, looks like the decision to remove the HAL team as a maintainer has already been implemented. Sorry for the noise.

posborne · 2019-05-17T22:42:29Z

bors r=therealprof

17: Remove #[deny(warnings)] r=therealprof a=dbrgn The library currently does not currently build anymore, because upstream libraries have added new deprecation warnings. A deprecation warning should not break compilation though. There was a post on Reddit about this about a year ago, but I can't find it anymore. I think adding a CI check step would be fine, but `#[deny(warnings)]` is a bit too much. These are the warnings: ``` warning: use of deprecated item 'hal::digital::OutputPin': Deprecated because the methods cannot return errors. Users should use the traits in digital::v2. --> src/lib.rs:111:6 | 111 | impl hal::digital::OutputPin for Pin { | ^^^^^^^^^^^^^^^^^^^^^^^ | = note: #[warn(deprecated)] on by default warning: use of deprecated item 'hal::digital::InputPin': Deprecated because the methods cannot return errors. Users should use the traits in digital::v2. --> src/lib.rs:121:6 | 121 | impl hal::digital::InputPin for Pin { | ^^^^^^^^^^^^^^^^^^^^^^ warning: use of deprecated item 'hal::digital::InputPin::is_high': Deprecated because the methods cannot return errors. Users should use the traits in digital::v2. --> src/lib.rs:131:15 | 131 | !self.is_high() | ^^^^^^^ ``` Co-authored-by: Danilo Bargen <mail@dbrgn.ch>

bors · 2019-05-17T22:45:01Z

Build failed

continuous-integration/travis-ci/push

dbrgn · 2019-05-19T21:42:49Z

The bors failure seems unrelated. What can we do to get this merged?

therealprof · 2019-05-19T22:23:35Z

I think it is me messing up the process because I'm not really a authorised reviewer on this repository. ;) If @posborne would just do bors r+, that might end up fine. ;)

posborne · 2019-05-20T04:19:38Z

bors r+

17: Remove #[deny(warnings)] r=posborne a=dbrgn The library currently does not currently build anymore, because upstream libraries have added new deprecation warnings. A deprecation warning should not break compilation though. There was a post on Reddit about this about a year ago, but I can't find it anymore. I think adding a CI check step would be fine, but `#[deny(warnings)]` is a bit too much. These are the warnings: ``` warning: use of deprecated item 'hal::digital::OutputPin': Deprecated because the methods cannot return errors. Users should use the traits in digital::v2. --> src/lib.rs:111:6 | 111 | impl hal::digital::OutputPin for Pin { | ^^^^^^^^^^^^^^^^^^^^^^^ | = note: #[warn(deprecated)] on by default warning: use of deprecated item 'hal::digital::InputPin': Deprecated because the methods cannot return errors. Users should use the traits in digital::v2. --> src/lib.rs:121:6 | 121 | impl hal::digital::InputPin for Pin { | ^^^^^^^^^^^^^^^^^^^^^^ warning: use of deprecated item 'hal::digital::InputPin::is_high': Deprecated because the methods cannot return errors. Users should use the traits in digital::v2. --> src/lib.rs:131:15 | 131 | !self.is_high() | ^^^^^^^ ``` Co-authored-by: Danilo Bargen <mail@dbrgn.ch>

bors · 2019-05-20T04:22:05Z

Build failed

continuous-integration/travis-ci/push

therealprof · 2019-05-20T07:18:32Z

Hm, okay, another problem with nightly... libc messed up:

error[E0425]: cannot find value `PTRACE_GETFPXREGS` in module `libc`
  --> /home/travis/.cargo/registry/src/git.luolix.top-1ecc6299db9ec823/nix-0.11.0/src/sys/ptrace.rs:77:9
   |
77 |         PTRACE_GETFPXREGS,
   |         ^^^^^^^^^^^^^^^^^
help: a constant with a similar name exists
   |
77 |         PTRACE_GETFPREGS,
   |         ^^^^^^^^^^^^^^^^
help: possible candidate is found in another module, you can import it into scope
   |
3  | use sys::ptrace::Request::PTRACE_GETFPXREGS;

rnestler · 2019-05-21T15:05:04Z

Hm, okay, another problem with nightly... libc messed up:

Why test this with nightly anyways? It compiles fine on stable.

ryankurte · 2019-05-22T02:44:49Z

@therealprof i ran into this today, tested to be resolved in nix-rust/nix#1055, i've asked them to publish a release nix-rust/nix#1061 which i guess will have to be individually bumped in sysfs_gpio, i2cdev and spidev and then updated here.

ryankurte · 2019-05-22T02:57:32Z

@rnestler it appears broken to me on both stable and nightly when cross compiling for arm. maybe we should add stable to the build matrix too?

therealprof · 2019-06-06T08:48:42Z

bors r+

17: Remove #[deny(warnings)] r=therealprof a=dbrgn The library currently does not currently build anymore, because upstream libraries have added new deprecation warnings. A deprecation warning should not break compilation though. There was a post on Reddit about this about a year ago, but I can't find it anymore. I think adding a CI check step would be fine, but `#[deny(warnings)]` is a bit too much. These are the warnings: ``` warning: use of deprecated item 'hal::digital::OutputPin': Deprecated because the methods cannot return errors. Users should use the traits in digital::v2. --> src/lib.rs:111:6 | 111 | impl hal::digital::OutputPin for Pin { | ^^^^^^^^^^^^^^^^^^^^^^^ | = note: #[warn(deprecated)] on by default warning: use of deprecated item 'hal::digital::InputPin': Deprecated because the methods cannot return errors. Users should use the traits in digital::v2. --> src/lib.rs:121:6 | 121 | impl hal::digital::InputPin for Pin { | ^^^^^^^^^^^^^^^^^^^^^^ warning: use of deprecated item 'hal::digital::InputPin::is_high': Deprecated because the methods cannot return errors. Users should use the traits in digital::v2. --> src/lib.rs:131:15 | 131 | !self.is_high() | ^^^^^^^ ``` Co-authored-by: Danilo Bargen <mail@dbrgn.ch>

bors · 2019-06-06T08:51:44Z

Build succeeded

continuous-integration/travis-ci/push

dbrgn · 2019-06-06T08:58:11Z

🎉

143: Remove #[deny(warnings)] r=ryankurte a=dbrgn It's an antipattern, see https://github.com/rust-unofficial/patterns/blob/master/anti_patterns/deny-warnings.md and rust-embedded/linux-embedded-hal#17 Co-authored-by: Danilo Bargen <mail@dbrgn.ch>

18: Move to digital v2 traits r=nastevens a=dbrgn The v1 traits are deprecated because they don't have a way to report errors. Gets rid of the deprecation warnings (which are hard errors until #17 is merged). Co-authored-by: Danilo Bargen <mail@dbrgn.ch>

Remove #[deny(warnings)]

9313b7f

The library currently does not currently build anymore, because upstream libraries have added new deprecation warnings. A deprecation warning should not break compilation though.

rust-highfive assigned nastevens May 14, 2019

rust-highfive added S-waiting-on-review Status: Review is incomplete T-embedded-linux labels May 14, 2019

therealprof approved these changes May 14, 2019

View reviewed changes

ryankurte approved these changes May 14, 2019

View reviewed changes

nastevens removed their assignment May 18, 2019

dbrgn mentioned this pull request May 19, 2019

Move to digital v2 traits #18

Merged

This was referenced May 22, 2019

bump nix to 0.14 to fix compilation issues rust-embedded/rust-sysfs-gpio#55

Merged

bump nix to 0.14 to fix libc issues rust-embedded/rust-i2cdev#49

Merged

[WIP] bump nix to 0.14 to fix libc issues rust-embedded/rust-spidev#15

Closed

posborne mentioned this pull request May 29, 2019

Use upstream nix rust-embedded/rust-spidev#16

Merged

bors bot merged commit 9313b7f into rust-embedded:master Jun 6, 2019

dbrgn deleted the remove-deny-warnings branch June 6, 2019 08:58

dbrgn mentioned this pull request Jun 11, 2019

Remove #[deny(warnings)] rust-embedded/embedded-hal#143

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove #[deny(warnings)] #17

Remove #[deny(warnings)] #17

dbrgn commented May 14, 2019

rust-highfive commented May 14, 2019

therealprof commented May 14, 2019

therealprof left a comment

hannobraun commented May 16, 2019

bors bot commented May 16, 2019

hannobraun commented May 16, 2019

posborne commented May 17, 2019

bors bot commented May 17, 2019

dbrgn commented May 19, 2019

therealprof commented May 19, 2019

posborne commented May 20, 2019

bors bot commented May 20, 2019

therealprof commented May 20, 2019

rnestler commented May 21, 2019

ryankurte commented May 22, 2019

ryankurte commented May 22, 2019

therealprof commented Jun 6, 2019

bors bot commented Jun 6, 2019

dbrgn commented Jun 6, 2019

Remove #[deny(warnings)] #17

Remove #[deny(warnings)] #17

Conversation

dbrgn commented May 14, 2019

rust-highfive commented May 14, 2019

therealprof commented May 14, 2019

therealprof left a comment

Choose a reason for hiding this comment

hannobraun commented May 16, 2019

bors bot commented May 16, 2019

hannobraun commented May 16, 2019

posborne commented May 17, 2019

bors bot commented May 17, 2019

Build failed

dbrgn commented May 19, 2019

therealprof commented May 19, 2019

posborne commented May 20, 2019

bors bot commented May 20, 2019

Build failed

therealprof commented May 20, 2019

rnestler commented May 21, 2019

ryankurte commented May 22, 2019

ryankurte commented May 22, 2019

therealprof commented Jun 6, 2019

bors bot commented Jun 6, 2019

Build succeeded

dbrgn commented Jun 6, 2019