Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Images are broken in the discovery book #4

Closed
japaric opened this issue Oct 4, 2018 · 5 comments
Closed

Images are broken in the discovery book #4

japaric opened this issue Oct 4, 2018 · 5 comments
Labels
bug Something isn't working T-resources

Comments

@japaric
Copy link
Member

japaric commented Oct 4, 2018

At least in the bookshelf version. See:

https://rust-embedded.github.io/bookshelf/discovery/04-meet-your-hardware/index.html

The standalone version of the discovery book does show the images:

https://rust-embedded.github.io/discovery/04-meet-your-hardware/README.html

@japaric japaric added bug Something isn't working T-resources labels Oct 4, 2018
@therealprof
Copy link
Contributor

cf. rust-embedded/book#38

@adamgreen
Copy link
Contributor

I was playing around with linkchecker tonight to see if I could see why it doesn't detect these missing image URLs. It seems like it treats the absolute links as external links so doesn't bother to check them. I was able to get it to detect the bad links by using this command line:

linkchecker --ignore-url "http.*" --check-extern doc

I used the --ignore-url option too since linkchecker gets a bunch of internal errors if it actually tries to validate links to external websites when I ran it on my Ubuntu VM.

@adamgreen
Copy link
Contributor

I have just created PR #9 to address this issue for the bookshelf repository as well.

@adamgreen
Copy link
Contributor

This is now fixed.

@adamgreig
Copy link
Member

Thanks @adamgreen!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working T-resources
Projects
None yet
Development

No branches or pull requests

4 participants