Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Relative links are missing bookshelf/discovery in URL #123

Closed
adamgreen opened this issue Oct 13, 2018 · 4 comments
Closed

Relative links are missing bookshelf/discovery in URL #123

adamgreen opened this issue Oct 13, 2018 · 4 comments

Comments

@adamgreen
Copy link
Contributor

adamgreen commented Oct 13, 2018 •
edited
Loading

Images aren't showing up in documentation. For example, if I navigate to https://rust-embedded.github.io/bookshelf/discovery/02-requirements/index.html none of the images linked from this page are rendered.

An example of a broken link found on this page:
https://rust-embedded.github.io/assets/f3.jpg

I think it should actually be:
https://rust-embedded.github.io/bookshelf/discovery/assets/f3.jpg
@adamgreen
Copy link
Contributor Author

As I continue to progress through this documentation, I see that there are other project relative links which are now broken.

The list of links at https://rust-embedded.github.io/bookshelf/discovery/03-setup/index.html#os-specific-instructions return a 404 error since they attempt to link to files at the root of the website instead of within the bookshelf/discovery folder.

@adamgreen adamgreen changed the title Images aren't showing up in documentation Relative links are missing bookshelf/discovery in URL Oct 13, 2018
@adamgreen
Copy link
Contributor Author

It appears that PR #121 is attempting to fix the image links part of this issue.

This was referenced Oct 14, 2018
Closed
Closed
This was referenced Oct 18, 2018
Merged
Merged
@ChouzArt
Copy link
Contributor

Didn't notice the 404 on those relative links. Could be more but already made a new PR to fix those too

bors bot added a commit that referenced this issue Oct 18, 2018
@bors @ChouzArt
Merge #131
7f65b8a 
131: To fix 03-setup/Readme.md references to next section links r=therealprof a=ChouzArt

As seen on #123 

Co-authored-by: Carlos <gsolracchz@gmail.com>
@adamgreen
Copy link
Contributor Author

This is a duplicate of rust-embedded/rust-embedded.github.io#4

bors bot added a commit that referenced this issue Oct 28, 2018
@bors @ChouzArt
Merge #130
403b71f 
130: To fix links with correct reference to assets folder r=thejpster a=ChouzArt

Cancelled a previous PR #121 in favor of this one. To make it cleaner using a new branch instead of my master.

#123 Also pointed to this issue.

Co-authored-by: Carlos <gsolracchz@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@adamgreen @ChouzArt