Release 0.6.0 #70
Merged
Release 0.6.0 #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @nastevens (rust-highfive has picked a reviewer for you, use r? to override) |
eldruin
force-pushed
the
release-0.6.0
branch
from
9805db6
to
dbe325d
Compare
|
bors try |
eldruin
force-pushed
the
release-0.6.0
branch
from
f6cbef5
to
c53a2b3
Compare
|
bors try |
nastevens
reviewed
Sep 24, 2021
| @@ -43,6 +41,7 @@ | |||
| //! ``` | |||
|
|
|||
| #![cfg_attr(feature = "async-tokio", allow(deprecated))] | |||
| #![doc(html_root_url = "https://docs.rs/sysfs-gpio/0.6.0")] | |||
There was a problem hiding this comment.
I don't think this is needed right? It seems like it'd be quickly out of date in any case.
Edit: I see the reminder in Cargo.toml so definitely intentional. Could you help me understand what this is doing please and why it's useful?
There was a problem hiding this comment.
Ah, this recommendation has been removed from the API guidelines: rust-lang/api-guidelines#230
I never liked it TBH. Thanks!
|
bors r+ |
|
👎 Rejected by too few approved reviews |
nastevens
approved these changes
Sep 24, 2021
|
bors r+ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉