Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump version to 0.18 and add missing CHANGELOG.md entries #499

Merged
merged 1 commit into from
Apr 17, 2021
Merged

Bump version to 0.18 and add missing CHANGELOG.md entries #499

merged 1 commit into from
Apr 17, 2021

Conversation

therealprof
Copy link
Contributor

r? adamgreig

Signed-off-by: Daniel Egger daniel@eggers-club.de

@rust-highfive
Copy link

r? @adamgreig

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-tools labels Apr 13, 2021
adamgreig
adamgreig previously approved these changes Apr 14, 2021
View reviewed changes
Copy link
Member

@adamgreig adamgreig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Successfully generated some STM32 PACs using 0.18 which build and run in a simple example.

@burrbull burrbull mentioned this pull request Apr 17, 2021
Closed
@therealprof
Bump version to 0.18 and add missing CHANGELOG.md entries
c85f4e9 
Signed-off-by: Daniel Egger <daniel@eggers-club.de>
@burrbull
Copy link
Member

bors r+

@therealprof therealprof marked this pull request as ready for review April 17, 2021 20:47
@therealprof therealprof requested a review from a team as a code owner April 17, 2021 20:47
@bors
Copy link
Contributor

bors bot commented Apr 17, 2021

Build succeeded:

@bors bors bot merged commit 71fdbff into master Apr 17, 2021
@bors bors bot deleted the 0.18 branch April 17, 2021 21:13
@therealprof
Copy link
Contributor Author

... and published.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@burrbull burrbull burrbull approved these changes

@adamgreig adamgreig adamgreig left review comments

Assignees

@adamgreig adamgreig

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-tools
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@therealprof @rust-highfive @burrbull @adamgreig