Add CHANGELOG.md entry checker to GHA workflows #500
Conversation
|
r? @ryankurte (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
S-waiting-on-review
.github/workflows/changelog.yml
Outdated
| @@ -0,0 +1,19 @@ | |||
| on: | |||
| pull_request_target: | |||
There was a problem hiding this comment.
Does it need to be pull_request_target? On the example for the action they seem to just use a normal pull_request.
There was a problem hiding this comment.
Not sure, it's a verbatim copy from the stm32f4xx-hal. 🤷🏻♂️
There was a problem hiding this comment.
Could you try with just pull_request? If that works it's somewhat more straightforward and safer.
|
Thanks, looks like it works. Currently it won't stop bors at all (if I bors+ this now, it should merge, I think) because it doesn't run on bors' push to staging and also bors isn't configured to care about it. I think this sort of makes sense - it should alert reviewers/users that the changelog is missing, but doesn't stop a change being r+'d if the reviewer thinks it's fine. I don't think the "apply label to allow it to pass without changelog" would work under bors anyway, so this is probably the best config. What do you think? Happy to merge as-is. |
Signed-off-by: Daniel Egger <daniel@eggers-club.de>
therealprof
force-pushed
the
check-changelog
branch
from
4690429
to
be1eeef
Compare
|
Oh, sorry, I didn't notice the force push. What did you change? |
|
As requested I changed |
I agree. Alerting the reviewer to a missing CHANGELOG entry should be okay. |
r? @adamgreig
Signed-off-by: Daniel Egger daniel@eggers-club.de