Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support for alternateGroup registers #506

Merged
merged 1 commit into from
Apr 17, 2021
Merged

support for alternateGroup registers #506

merged 1 commit into from
Apr 17, 2021

Conversation

burrbull
Copy link
Member

See #504

@rust-highfive
Copy link

r? @reitermarkus

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-tools labels Apr 15, 2021
@burrbull burrbull changed the title [WIP] support of alternateGroup registers support for alternateGroup registers Apr 15, 2021
@burrbull burrbull marked this pull request as ready for review April 15, 2021 19:16
@burrbull burrbull requested a review from a team as a code owner April 15, 2021 19:16
@burrbull burrbull mentioned this pull request Apr 15, 2021
Closed
@burrbull burrbull force-pushed the alternate-group branch 2 times, most recently from b0f3a66 to 0f965f0 Compare April 16, 2021 06:54
therealprof
therealprof reviewed Apr 16, 2021
View reviewed changes
Copy link
Contributor

@therealprof therealprof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me in general. Where is this needed?

@burrbull
Copy link
Member Author

Looks good to me in general. Where is this needed?

Some vendors (like Atmel, or Freescale) use alternateGroup to specify registers with that can use different set of fields in different modes.
I've just added this group name as prefix for register name. So now there are no conflicts.

@burrbull
Copy link
Member Author

cc @adamgreig @john-terrell

@burrbull burrbull mentioned this pull request Apr 17, 2021
Closed
therealprof
therealprof approved these changes Apr 17, 2021
View reviewed changes
Copy link
Contributor

@therealprof therealprof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

bors r+

@bors
Copy link
Contributor

bors bot commented Apr 17, 2021

Build succeeded:

@bors bors bot merged commit 89fe907 into master Apr 17, 2021
@bors bors bot deleted the alternate-group branch April 17, 2021 18:29
@nickray nickray mentioned this pull request May 2, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@therealprof therealprof therealprof approved these changes

Assignees

@reitermarkus reitermarkus

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-tools
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@burrbull @rust-highfive @therealprof @reitermarkus