Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shanghai eips 3651, 3855, 3860 #152

Merged
merged 7 commits into from
Mar 8, 2023

Conversation

tgmichel
Copy link
Contributor

@tgmichel tgmichel commented Feb 8, 2023

  • EIP-3651 Warm COINBASE
  • EIP-3855 PUSH0 instruction
  • EIP-3860 Limit and meter initcode

See https://github.com/ethereum/execution-specs/blob/master/network-upgrades/mainnet-upgrades/shanghai.md

@tgmichel
Copy link
Contributor Author

tgmichel commented Feb 9, 2023

@sorpaas please take a look

runtime/src/eval/system.rs Outdated Show resolved Hide resolved
Copy link
Member

@sorpaas sorpaas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PUSH0 should be added to evm_core instead of evm_runtime. Otherwise currently LGTM.

@tgmichel
Copy link
Contributor Author

@sorpaas also pushed 397b3c0, was missing some init code related change. PTAL.

@sorpaas sorpaas merged commit 2e9c3b7 into rust-ethereum:master Mar 8, 2023
@vimpunk
Copy link
Contributor

vimpunk commented Mar 15, 2023

Shouldn't there be tests in the evm-test repo for this change? I don't see any Shanghai tests in there, the ethtests submodule needs to be updated.

Is anyone working on this? I'll take it if no one is.

@joshuajbouw
Copy link
Contributor

I didn't see it either. Let's just own it @mandreyel. Thanks @tgmichel for tackling this we were just about to handle it. Might be a good idea in the future to have a message stream where we can discuss owning tasks like these, probably in the EVM matrix room for this project.

This was referenced Jul 25, 2023
zjb0807 added a commit to AcalaNetwork/Acala that referenced this pull request Jan 22, 2024
zjb0807 added a commit to AcalaNetwork/Acala that referenced this pull request Jan 29, 2024
* update PrecompileHandle ref: rust-ethereum/evm#122

* update fee calculation ref: rust-ethereum/evm#132

* add code_size/code_hash fn in StackState trait ref: rust-ethereum/evm#140

* update evm call stack ref: rust-ethereum/evm#136

* update evm call stack ref: rust-ethereum/evm#155

* add shanghai eips 3651, 3855, 3860 ref: rust-ethereum/evm#152

* update is_precompile ref: rust-ethereum/evm#157

* fix eip-3860 ref: rust-ethereum/evm#160

* update runtime config ref: rust-ethereum/evm#161

* add eip-4399 ref: rust-ethereum/evm#162

* fix eip-2618 ref: rust-ethereum/evm#163

* fix nonce back to U256 ref: rust-ethereum/evm#166

* remove exit_substate in create functions ref: rust-ethereum/evm#168

* record external cost ref: rust-ethereum/evm#170

* add record_external_operation ref: rust-ethereum/evm#171

* add storage_growth ref: rust-ethereum/evm#173

* update evm

* switch to shanghai hardfork

* update ecrecover ref: polkadot-evm/frontier#964 (#2696)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants