Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: no-std dependencies #244

Closed
wants to merge 1 commit into from
Closed

Fix: no-std dependencies #244

wants to merge 1 commit into from

Conversation

mrLSD
Copy link
Contributor

@mrLSD mrLSD commented Nov 29, 2023

Description

🦩 It solves issues for no-std build:

To reproduce, just run ⬇️:

cargo build --no-default-features

@mrLSD mrLSD mentioned this pull request Nov 30, 2023
Merged
2 tasks
sorpaas
sorpaas reviewed Nov 30, 2023
View reviewed changes
interpreter/src/call_create.rs
@@ -1,5 +1,8 @@
//! Call and create trap handler.

#[cfg(not(feature = "std"))]
use crate::Vec;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's use alloc::vec::Vec for consistency.

@sorpaas
Copy link
Member

sorpaas commented Nov 30, 2023

I think let's do this together with #246. Looks like all those changes are included there anyway.

@sorpaas sorpaas closed this Nov 30, 2023
@mrLSD mrLSD deleted the feat/fix-no-std branch December 6, 2023 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sorpaas sorpaas sorpaas left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mrLSD @sorpaas