-
Notifications
You must be signed in to change notification settings - Fork 360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support transient storage opcodes (EIP-1153) #278
feat: support transient storage opcodes (EIP-1153) #278
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some remarks to improve perf but overall it's good
@RomarQ I think it's important that the new opcodes should only be enabled when the Cancun fork is used and not for previous forks. We should add a flag that is set to true when the Cancun fork is chosen that enable or disable the new opcodes. Something similar to what was done for evm/src/standard/gasometer/mod.rs Lines 413 to 415 in f7a23df
|
Done, thanks for the remark 👍 |
@RomarQ Please resolve the conflicts |
Done |
This PR adds 2 new opcodes (
TLOAD
andTSTORE
) for manipulating state that behaves almost identically to storage but is discarded after every transaction.These new instructions were introduced by EIP-1153 and included in Cancun fork.
Running the tests located at
ethtests/GeneralStateTests/Cancun/stEIP1153-transientStorage
will require the changes present in #280