Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: burn base fee when eip-1559 is enabled (>= london fork) #289

Merged
merged 1 commit into from
Jun 4, 2024

Conversation

RomarQ
Copy link
Contributor

@RomarQ RomarQ commented Jun 4, 2024

Also adds a new configuration property eip_1159_enabled which when set to true, burns the base fee, instead of sending it to the coinbase address.

An important aspect of this fee system is that miners only get to keep the priority fee. The base fee is always burned (i.e. it is destroyed by the protocol). This ensures that only ETH can ever be used to pay for transactions on Ethereum, cementing the economic value of ETH within the Ethereum platform and reducing risks associated with miner extractable value (MEV). Additionally, this burn counterbalances Ethereum inflation while still giving the block reward and priority fee to miners. Finally, ensuring the miner of a block does not receive the base fee is important because it removes miner incentive to manipulate the fee in order to extract more fees from users.

@RomarQ RomarQ mentioned this pull request Jun 4, 2024
@koushiro koushiro changed the title burn base fee when eip-1559 is enabled (>= london fork) feat: burn base fee when eip-1559 is enabled (>= london fork) Jun 4, 2024
@koushiro koushiro merged commit 8168ca1 into rust-ethereum:master Jun 4, 2024
3 checks passed
@@ -156,6 +158,7 @@ impl Config {
has_push0: false,
eip_1153_enabled: false,
eip_5656_enabled: false,
eip_1559_enabled: false,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hope we can change those to something more descriptive. For example, burn_base_fee. We can add in the docs that this is related to EIP-1559.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants