Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: expose account_mut #92

Merged
merged 1 commit into from
Feb 7, 2022
Merged

Conversation

gakonst
Copy link
Contributor

@gakonst gakonst commented Jan 24, 2022

as title, we need this to expose a mutable ref to an account so that we can override its nonce in foundry-rs/foundry#554

@sorpaas
Copy link
Member

sorpaas commented Jan 28, 2022

Can you create a set_nonce function in the executor instead?

@gakonst
Copy link
Contributor Author

gakonst commented Jan 28, 2022

@sorpaas The motivation is to avoid having to add a setter for everything because I'd like to have access to full internals, is that a big issue?

I'm OK with it otherwise

@gakonst
Copy link
Contributor Author

gakonst commented Jan 31, 2022

@sorpaas I gave this an attempt locally, it requires changing the Handler trait and implementing a bunch of methods for passing thru the values, I'd really prefer to just expose this function globally as a simple change without further expanding the interfaces elsewhere.

@gakonst
Copy link
Contributor Author

gakonst commented Feb 6, 2022

@sorpaas Updated the PR based on your comment from Matrix!

@gakonst
Copy link
Contributor Author

gakonst commented Feb 7, 2022

Nice - thank you. @sorpaas could we merge? The CI errors seem unrelated.

@sorpaas
Copy link
Member

sorpaas commented Feb 7, 2022

Please merge master and it should fix the CI.

@gakonst
Copy link
Contributor Author

gakonst commented Feb 7, 2022

Rebased! Should be good now. Thanks @sorpaas

@sorpaas sorpaas merged commit a391051 into rust-ethereum:master Feb 7, 2022
@gakonst gakonst deleted the patch-1 branch February 7, 2022 09:25
olonho pushed a commit to olonho/sputnikvm that referenced this pull request Feb 17, 2022
olonho pushed a commit to olonho/sputnikvm that referenced this pull request Feb 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants