-
Notifications
You must be signed in to change notification settings - Fork 309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(FilterMapOk
): implement DoubleEndedIterator
#950
feat(FilterMapOk
): implement DoubleEndedIterator
#950
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #950 +/- ##
==========================================
+ Coverage 94.38% 94.52% +0.13%
==========================================
Files 48 49 +1
Lines 6665 7046 +381
==========================================
+ Hits 6291 6660 +369
- Misses 374 386 +12 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You did not need to make a merge commit.
.by_ref().rev().find_map(
is verbose but it's not unprecedented like for Unique::next_back
and it's fine.
Wanted to rebase, but messed up. Like my pr's to be up to date :) |
No prob, the commit history is not that clean anyway. |
Hmm, maybe the other option would be The |
Benchmarked against the The |
DoubleEndedIterator
implementation forFilterMapOk
analog to #948.Hope
rev()
is the right thing here, asrfind_map
does not exist (#949).Refs: #947