forked from rust-lang/rust
-
Notifications
You must be signed in to change notification settings - Fork 7
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Auto merge of rust-lang#105457 - GuillaumeGomez:prevent-auto-blanket-…
…impl-retrieval, r=notriddle rustdoc: Prevent auto/blanket impl retrieval if there were compiler errors Fixes rust-lang#105404. I'm not sure happy about this fix but since it's how passes work (ie, even if there are errors, it runs all passes), I think it's fine as is. Just as a sidenote: I also gave a try to prevent running all passes in case there were compiler errors but then a lot of rustdoc tests were failing so I went for this fix instead. r? `@notriddle`
- Loading branch information
Showing
3 changed files
with
45 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
// This test ensures that it's not crashing rustdoc. | ||
|
||
pub struct Foo<'a, 'b, T> { | ||
field1: dyn Bar<'a, 'b,>, | ||
//~^ ERROR | ||
//~^^ ERROR | ||
} | ||
|
||
pub trait Bar<'x, 's, U> | ||
where U: 'x, | ||
Self:'x, | ||
Self:'s | ||
{} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,26 @@ | ||
error[E0107]: this trait takes 1 generic argument but 0 generic arguments were supplied | ||
--> $DIR/unable-fulfill-trait.rs:4:17 | ||
| | ||
LL | field1: dyn Bar<'a, 'b,>, | ||
| ^^^ expected 1 generic argument | ||
| | ||
note: trait defined here, with 1 generic parameter: `U` | ||
--> $DIR/unable-fulfill-trait.rs:9:11 | ||
| | ||
LL | pub trait Bar<'x, 's, U> | ||
| ^^^ - | ||
help: add missing generic argument | ||
| | ||
LL | field1: dyn Bar<'a, 'b, U,>, | ||
| +++ | ||
|
||
error[E0227]: ambiguous lifetime bound, explicit lifetime bound required | ||
--> $DIR/unable-fulfill-trait.rs:4:13 | ||
| | ||
LL | field1: dyn Bar<'a, 'b,>, | ||
| ^^^^^^^^^^^^^^^^ | ||
|
||
error: aborting due to 2 previous errors | ||
|
||
Some errors have detailed explanations: E0107, E0227. | ||
For more information about an error, try `rustc --explain E0107`. |