Skip to content
This repository has been archived by the owner on Aug 16, 2021. It is now read-only.

Do not capture backtrace without RUST_BACKTRACE=1 #7

Closed
pravic opened this issue Jul 20, 2016 · 4 comments
Closed

Do not capture backtrace without RUST_BACKTRACE=1 #7

pravic opened this issue Jul 20, 2016 · 4 comments

Comments

@pravic
Copy link

pravic commented Jul 20, 2016

Subj.

The problem described here: rust-lang-nursery/rustup.rs#591. Guess issue related to this crate since backtrace-rs is explicit thing to deal with it.

@brson
Copy link
Contributor

brson commented Jul 21, 2016

Thanks for filing this. I'm amenable to making this behavior an option at least, but I also want to figure out why you are seeing so much disk thrashing on windows - it shouldn't be that expensive to capture a backtrace. Many languages capture them for every exception, and that's a model I want to support, just having backtraces always available.

@pravic
Copy link
Author

pravic commented Jul 21, 2016

I'll answer in that issue better.

@pravic
Copy link
Author

pravic commented Jul 21, 2016

Many languages capture them for every exception, and that's a model I want to support, just having backtraces always available.

We can use RtlCaptureStackBackTrace, it does not require debug symbols to work.

@brson
Copy link
Contributor

brson commented Jul 29, 2016

Let's just go ahead and do this. No backtraces unless RUST_BACKTRACE is set and not equal to "0". The backtrace field will need to become an option.

@brson brson closed this as completed in df58ffe Aug 11, 2016
brson added a commit that referenced this issue Aug 11, 2016
Only generate backtraces with RUST_BACKTRACE set (closes #7)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants