Skip to content
This repository has been archived by the owner on Aug 16, 2021. It is now read-only.

fix for backtrace 0.3.10 #282

Closed
wants to merge 2 commits into from
Closed

fix for backtrace 0.3.10 #282

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7f0de79
fix for backtrace 0.3.10
RalfJung Dec 11, 2018
58e87b3
work woth old backtrace, to support Rust 1.18
RalfJung Dec 11, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/backtrace/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,15 +129,15 @@ with_backtrace! {
impl Debug for Backtrace {
fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result {
if let Some(bt) = self.internal.as_backtrace() {
bt.fmt(f)
Debug::fmt(bt, f)
} else { Ok(()) }
}
}

impl Display for Backtrace {
fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result {
if let Some(bt) = self.internal.as_backtrace() {
bt.fmt(f)
Debug::fmt(bt, f)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@RalfJung I think this should be Display.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That would require bumping the minimal version of backtrace, though.

And anyway I closed this PR because #279 does the same thing.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, yeah, I was trying to answer: #279 (comment)

But I didn't know about the minimal version requirement.

} else { Ok(()) }
}
}
Expand Down