This repository has been archived by the owner on Aug 20, 2021. It is now read-only.
Fix ignored error in example #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previous to this change, the Err result from TempDir::new was silently ignored. Fix by handling the Err result using the '?' operator.
KodrAus
reviewed
Jan 1, 2018
README.md
Outdated
| dir.close()?; | ||
| } | ||
| use std::io; | ||
| use std::io::Write; |
There was a problem hiding this comment.
We could simplify this to use std::io::{self, Write};
KodrAus
approved these changes
Jan 1, 2018
There was a problem hiding this comment.
Thanks @rfdonnelly! I've left a really minor comment about one of the use statements but otherwise this looks good to me!
|
@KodrAus I wasn't aware you could use |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes three changes to the example in the README:
Errresult fromTempDir::newusestatements necessary to get example to compileio:Resulttype