Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use mdbook-linkcheck #572

Closed
pickfire opened this issue Feb 22, 2020 · 5 comments
Closed

Use mdbook-linkcheck #572

pickfire opened this issue Feb 22, 2020 · 5 comments
Labels

Comments

@pickfire
Copy link
Contributor

https://lib.rs/crates/mdbook-linkcheck

It seemed better integrated with mdbook and uses the existing flow, mdbook build.

@KappaDistributive
Copy link
Contributor

Note that this will also require updating mdbook to at least version 0.3.0.

@pickfire
Copy link
Contributor Author

I wonder if there is still a maintainer for rust cookbook.

@KappaDistributive
Copy link
Contributor

@AndyGauge is still around -- don't worry.

As it is the nature with these side projects, attention/activity will fluctuate.

@AndyGauge
Copy link
Collaborator

I won't rewrite the build scripts to use a different link checker, but will accept a PR that correctly moves to a rust solution.

@pickfire
Copy link
Contributor Author

pickfire commented Jun 1, 2020

I tried doing this but looks like the link checker implementation is quite different and there are some stuff that is not valid (I also found broken links at https://rust-lang-nursery.github.io/rust-cookbook/web/clients.html). I got confused on what how the link works, the error is pointing to some random place.

@AndyGauge AndyGauge added the 2024 label Dec 1, 2024
Arteiii added a commit to Arteiii/rust-cookbook that referenced this issue Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants