Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add feature for testing colored output easier #82

Merged
merged 1 commit into from
Feb 29, 2024

Conversation

Muscraft
Copy link
Member

In cargo#13461, it was noticed that the default colors being platform-specific made testing colored output quite challenging. This PR adds a feature that makes the colors the same across the board, which should be enabled when testing colored output.

@Muscraft Muscraft added the C-enhancement Category: enhancement label Feb 29, 2024
src/renderer/mod.rs Outdated Show resolved Hide resolved
src/renderer/mod.rs Outdated Show resolved Hide resolved
src/renderer/mod.rs Outdated Show resolved Hide resolved
@Muscraft Muscraft force-pushed the testing-colors-feature branch 2 times, most recently from f2fc618 to 8a29fa8 Compare February 29, 2024 21:39
@epage epage merged commit 8ab88a6 into rust-lang:master Feb 29, 2024
15 checks passed
@Muscraft Muscraft deleted the testing-colors-feature branch February 29, 2024 21:42
bors added a commit to rust-lang/cargo that referenced this pull request Mar 2, 2024
feat: Use consistent colors when testing

In cargo#13461, it was [noted that `annotate-snippets`](#13461 (comment)) made testing hard as it outputs platform specific colors. To fix this I created [annotate-snippets-rs#82](rust-lang/annotate-snippets-rs#82), which added a feature to make the output platform agnostic when enabled. This makes it so glob syntax does not need to be used when matching colored output.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-enhancement Category: enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants