Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Does not compile with Rust 1.18 #135

Closed
RalfJung opened this issue Dec 11, 2018 · 3 comments
Closed

Does not compile with Rust 1.18 #135

RalfJung opened this issue Dec 11, 2018 · 3 comments

Comments

@RalfJung
Copy link
Member

RalfJung commented Dec 11, 2018 •
edited
Loading

The failure crate, which depends on this, supports Rust versions as far back as Rust 1.18. This crate seems to only test on CI against current stable. It is hence not entirely surprising that backtrace currently fails to build against Rust 1.18.
@RalfJung
Copy link
Member Author

This could be resolved by bumping the minimal Rust version required by failure, or by fixing backtrace-rs -- but either way it seems the two crates should sync their CI in terms of which baseline Rust version they test.

@alexcrichton
Copy link
Member

I'm not personally invested in making crates compile on such old versions of rustc, but I'm happy to merge PRs to fix compatibility!

@azriel91 azriel91 mentioned this issue Dec 11, 2018
Closed
azriel91 added a commit to azriel91/backtrace-rs that referenced this issue Dec 12, 2018
@azriel91
Include Rust 1.18 compatible implementations.
06f00c4 
Issue rust-lang#135
@azriel91 azriel91 mentioned this issue Dec 12, 2018
Merged
azriel91 added a commit to azriel91/backtrace-rs that referenced this issue Dec 12, 2018
@azriel91
Use autocfg crate to detect Rust features.
37a0753 
Issue rust-lang#135
azriel91 added a commit to azriel91/backtrace-rs that referenced this issue Dec 12, 2018
@azriel91
Include Rust 1.25.0 compatible implementations.
03147a5 
Issue rust-lang#135
azriel91 added a commit to azriel91/backtrace-rs that referenced this issue Dec 13, 2018
@azriel91
Indicate no_std support is only available on Rust >= 1.30.0.
4c8bdb1 
Issue rust-lang#135
@alexcrichton
Copy link
Member

I'm gonna close this with #137 merged!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@alexcrichton @RalfJung