Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Miri backtraces #372

Merged
merged 1 commit into from
Sep 29, 2020
Merged

Conversation

Aaron1011
Copy link
Member

Companion to rust-lang/miri#1559

@alexcrichton
Copy link
Member

Looks reasonable to me, thanks for this! I figure it's probably best to wait for the companion PR to merge first before this?

@Aaron1011
Copy link
Member Author

I think the PRs should be reviewed together, but this PR should be merged first. That will allow us to add Miri tests on the backtrace-rs side once a nightly with the new Miri is available.

@alexcrichton
Copy link
Member

Ok seems reasonable to merge then, but looks like rustfmt is needed?

@Aaron1011
Copy link
Member Author

Oops, I didn't realize which repository I was commenting on. I meant to say that the Miri PR should be merged first.

@alexcrichton
Copy link
Member

Ah makes sense! If you can ping me when the upstream PR lands I'd be happy to merge this one!

@Aaron1011
Copy link
Member Author

Unfortunately, the test suite does not currently pass under Miri, so the actual content of this PR isn't being tested by CI.

However, this PR can be tested locally by running a simple program (e.g. println!("{:?}", backtrace::Backtrace::new())) under Miri, and observing the output.

I plan to do some follow-up work to get the test suite passing under Miri.

@Aaron1011
Copy link
Member Author

@alexcrichton The Miri PR had landed, so this PR is ready to be merged.

@alexcrichton
Copy link
Member

Ok, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants