Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add initial 1.52.0 post #822

Merged
merged 5 commits into from
May 6, 2021
Merged

Conversation

Mark-Simulacrum
Copy link
Member

This cycle didn't have a lot of notable stabilizations or changes in the language or standard library so I ended up keeping things pretty concise. If someone has particular things they'd like to highlight that seems positive - though I'd rather not devote too much time to something minor - we can definitely iterate further.

r? @rust-lang/release
cc @rust-lang/core

@Mark-Simulacrum Mark-Simulacrum requested a review from a team as a code owner April 23, 2021 15:14
@Mark-Simulacrum
Copy link
Member Author

Ok, made some adjustments - I feel like it's missing some structure (maybe headings or so) but then the sections get really small, not sure what to do about that. Maybe just some better flow would work.

@pietroalbini
Copy link
Member

Wow, I didn't know the cargo check/cargo clippy bug was finally fixed. That's a huge UX improvements for people not using an IDE, and it deserves to be the first thing mentioned in the post IMO (with its own section).

That leaves loop {} as the only minor change, and I guess we could either remove it or add it as its own section below the Clippy change. I'm not familiar enough with the loop {} change to know whether it's important for it to be featured in the post.

@Mark-Simulacrum
Copy link
Member Author

Heh, I don't use clippy ~at all myself so it's not really that big a deal in my eyes, but I can uplift it a bit into its own section. I think doing that will make it reasonable to drop the loop {} thing, it's not really a big deal, mostly there as a "well nothing else".

@flip1995
Copy link
Member

Oh yeah, this is a pretty big thing for Clippy. This bug was around for years and it is an example of successful collaboration between the cargo and the Clippy team to finally get this fixed.

@Mark-Simulacrum
Copy link
Member Author

Ok, I changed this to focus on just Clippy -- I am open to suggestions further though.

flip1995
flip1995 previously approved these changes Apr 30, 2021
Copy link
Member

@flip1995 flip1995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clippy part LGTM

Copy link
Member

@pietroalbini pietroalbini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks Mark for writing the post this cycle!

posts/2021-05-06-Rust-1.52.0.md Outdated Show resolved Hide resolved
pietroalbini
pietroalbini previously approved these changes May 3, 2021
Copy link
Member

@pietroalbini pietroalbini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was supposed to be an approval 😅

@Mark-Simulacrum Mark-Simulacrum dismissed stale reviews from pietroalbini and flip1995 via d45f2af May 3, 2021 13:02
Co-authored-by: Pietro Albini <pietro@pietroalbini.org>
@pietroalbini pietroalbini merged commit 9f11010 into rust-lang:master May 6, 2021
@Mark-Simulacrum Mark-Simulacrum deleted the 1.52-post branch July 9, 2022 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants