Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.54 release blog post #870

Merged
merged 10 commits into from
Jul 29, 2021
Merged

1.54 release blog post #870

merged 10 commits into from
Jul 29, 2021

Conversation

Mark-Simulacrum
Copy link
Member

I have not had a chance to fill in the stabilized APIs and some feedback from the Zulip thread is still unaddressed; it would be great for concrete suggestions on how to improve things. General review is of course appreciated as well.

r? @pietroalbini

cc @rust-lang/release

@Mark-Simulacrum Mark-Simulacrum requested a review from a team as a code owner July 22, 2021 19:22
Co-authored-by: Josh Triplett <josh@joshtriplett.org>
@calebcartwright
Copy link
Member

Realize rustfmt info isn't typically included in the release notes, but would it be worth including a footnote (not sure where) for rust-lang/rust#86424?

Maybe something like:

There was a bug in rustfmt on 1.53 where rustfmt wasn't seeing certain files and was unable to format them. That rustfmt bug has been fixed so users may see formatting diffs on 1.54 since rustfmt will be seeing some files for the first time since 1.52

Mark-Simulacrum and others added 5 commits July 27, 2021 12:49
Co-authored-by: XAMPPRocky <4464295+XAMPPRocky@users.noreply.github.com>
Co-authored-by: XAMPPRocky <4464295+XAMPPRocky@users.noreply.github.com>
Co-authored-by: XAMPPRocky <4464295+XAMPPRocky@users.noreply.github.com>
Co-authored-by: Esteban Kuber <estebank@users.noreply.github.com>
@pietroalbini pietroalbini merged commit 3612e0c into rust-lang:master Jul 29, 2021
@pietroalbini pietroalbini deleted the 1.54 branch July 29, 2021 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants