You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This is a small change which will give improved accessibility for the handful of places we use <span class="keystroke">, e.g. <span class="keystroke">ctrl-c</span>. Right now, there is no CSS or anything associated with that, and since it is just a span with no other information, screen readers won’t make anything of it either. Using <kbd> will automatically get reasonably good styling—GitHub is a little different, but gives a good idea of how it can look: ctrlc. Then screen readers can expose that (or not!) as they choose, but it at least conveys the appropriate semantics. To land it, we will also need to update the existing code which strips out those spans.
The text was updated successfully, but these errors were encountered:
This is a small change which will give improved accessibility for the handful of places we use
<span class="keystroke">
, e.g.<span class="keystroke">ctrl-c</span>
. Right now, there is no CSS or anything associated with that, and since it is just aspan
with no other information, screen readers won’t make anything of it either. Using<kbd>
will automatically get reasonably good styling—GitHub is a little different, but gives a good idea of how it can look: ctrlc. Then screen readers can expose that (or not!) as they choose, but it at least conveys the appropriate semantics. To land it, we will also need to update the existing code which strips out thosespan
s.The text was updated successfully, but these errors were encountered: