Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

closures: replace "is called" with "is defined" #2556

Merged
merged 1 commit into from
Feb 12, 2021
Merged

closures: replace "is called" with "is defined" #2556

merged 1 commit into from
Feb 12, 2021

Commits on Jan 4, 2021

  1. closures: replace "is called" with "is defined" 

    - Confusing "call" with "define" is especially unfortunate when
  documenting closures.
  The previous text was "... called in only ONE place ... we're still
  calling the closure TWICE" - clearly wrong.

- Also expand vague "define code" earlier in the page to the more
  explicit "refer to `simulated_expensive_calculation`". "define code"
  was especially vague considering 1. this is dummy code that doesn't
  really define anything, and 2. the code gets moved when changing
  from function to closure.
    Marc Herbert committed Jan 4, 2021
    Configuration menu
    Copy the full SHA
    8acef6c View commit details
    Browse the repository at this point in the history