Fix an off-by-one error when calculating current nightly date in local #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spastorino
approved these changes
Oct 22, 2020
|
Looks good, can you rebase? |
tesuji
force-pushed
the
112-off-by-one
branch
from
990f01f to
a18023a
Compare
|
Done. |
|
I have just hit #112. When is the next release scheduled? From what I can see, this fix is on |
|
@EliaGeretto there's no schedule but I could release with the stuff we have right now on master. Someone needs to provide a PR adding the new changes since last version to our changelog and then I could merge and release ;). |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix #112.