Default to --access github
#307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I've been using `cargo-bisect-rustc` for a while now, and `--access github` has never caused any problems. Maybe it can run into ratelimiting in extreme cases, but the user should then just use `git`. Meanwhile, git is a very confusing default as it will suddelny just start cloning the repo unless you were very careful when installing.
|
I have not used the github access method much, but I'm game to try. It certainly will be a better default experience as long as it is not rate limited. @oli-obk what do you think? |
|
I think it is rate limited, but I've never hit the limit in practice when doing one-off bisections (or even two or three). |
|
The unauthenticated rate limit is 60 requests/hour/IP, which should be more than enough for bisecting, outside heavily NATted connections (I would assume it only does one request per run?). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been using
cargo-bisect-rustcfor a while now, and--access githubhas never caused any problems. Maybe it can run intoratelimiting in extreme cases, but the user should then just use
git.Meanwhile, git is a very confusing default as it will suddelny just
start cloning the repo unless you were very careful when installing.