Check if commit is from bors #318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue where if a SHA commit is given that isn't a bors commit, it would result in a confusing panic message about two sha's not being equal.
The LocalGit backend handled this, but the GitHub backend did not. The solution here is to lift the check up to a higher level. It will fetch the start and end commits, and check the author of them.
This required a few code changes, since the committer info wasn't exposed. In summary:
committerfield to theCommitobject. Then added the necessary code to add that info.bisect_ci_via, check the start/end are by bors before querying for the range of commits.GithubCommit'sauthorandcommitterto beOptionto more correctly follow GitHub's API (since they can be nil).