Stop stripping and LTO #334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
*Stop stripping*: Stripping symbols here is bad, because it makes the binary completely opaque and undebbuggable, should something ever go wrong. The binary size benefit is very minor, this program is supposed to run on desktop computers with tons of disk space. The tradeoff is bad. *Stop LTO*: The same binary size non-concerns as stripping apply. Also, speed basically doesn't matter here. Meanwhile, we want this program to be `cargo install`-able, so compile times matter. Again, the tradeoff is bad.
|
If anyone cares about sacrificing things for 4 megabytes like in #157 they can always manually override the setting for their builds, this is just the default. |
|
@oli-obk you have approved the other pr |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stop stripping:
Stripping symbols here is bad, because it makes the binary completely opaque and undebbuggable, should something ever go wrong. The binary size benefit is very minor, this program is supposed to run on desktop computers with tons of disk space. The tradeoff is bad.
I like to follow the rule of "do not ever strip symbols unless you absolutely need to", at least for programs on dev systems.
Stop LTO:
The same binary size non-concerns as stripping apply. Also, speed basically doesn't matter here. Meanwhile, we want this program to be
cargo install-able, so compile times matter. Again, the tradeoff is bad.