-
Notifications
You must be signed in to change notification settings - Fork 2.4k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Auto merge of #8611 - hbina:rename_into_url, r=ehuss
Renames SourceId::into_url -> SourceId::as_url While studying the source code, I am surprised to see that `into_url` does not actually consume its caller when a function with such name usually does. Additionally, there is a trait in `cargo::util::IntoUrl` with the same and does exactly what you expect, consumes itself and yields a `CargoResult<Url>`. I hope this is not too nitpicky. Thank you!
- Loading branch information
Showing
3 changed files
with
7 additions
and
7 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters