-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extra "Updating index" messages after publishing a crate #11304
Comments
I think this only happens with git registries, so the problem will diminish over time. There is the potential for multiple exit points, so RAII would be the most robust way of handling this. At first, I thought lifetimes made that impossible due conflicting access to |
From my experience it happens on crates.io so that seems pretty widespread. Since cargo is already capable of showing progress bars I wonder if something like that could be used here instead. It almost looks like a bug now. |
|
Add more information to wait-for-publish This reworks the console output when waiting for a publish to be available: * Shows a "Published" status to try to make it clear that the publish is complete, and that Cargo is moving to a separate phase. * Removes the repeated status bars and updating messages, and uses a single progress bar to track the publish. * Provides more of a description of why Cargo is waiting to try to make it clearer what is happening. * Provides more information when a timeout happens to try to explain what might be happening. * Shows a "Completed" message at the end to let the user know that everything is complete. Comparing the output: Before (with git): ``` Updating crates.io index Packaging delay v0.0.2 (/Users/eric/Proj/rust/cargo/target/tmp/cit/t0/foo) Packaged 3 files, 761.0B (569.0B compressed) Uploading delay v0.4.27 (/Users/eric/Proj/rust/cargo/target/tmp/cit/t0/foo) Updating crates.io index Waiting on `delay` to propagate to crates.io index (ctrl-c to wait asynchronously) Updating crates.io index Updating crates.io index Updating crates.io index Updating crates.io index Updating crates.io index Updating crates.io index Updating crates.io index Updating crates.io index Updating crates.io index Updating crates.io index ``` Before (with sparse): ``` Updating crates.io index Packaging delay v0.0.2 (/Users/eric/Proj/rust/cargo/target/tmp/cit/t0/foo) Packaged 3 files, 761.0B (569.0B compressed) Uploading delay v0.0.2 (/Users/eric/Proj/rust/cargo/target/tmp/cit/t0/foo) Updating crates.io index Waiting on `delay` to propagate to crates.io index (ctrl-c to wait asynchronously) Fetch [=============================> ] 36 complete; 1 pending ``` New (git or sparse): ``` Updating crates.io index Packaging delay v0.0.2 (/Users/eric/Proj/rust/cargo/target/tmp/cit/t0/foo) Packaged 3 files, 761.0B (569.0B compressed) Uploading delay v0.0.2 (/Users/eric/Proj/rust/cargo/target/tmp/cit/t0/foo) Uploaded delay v0.0.2 (/Users/eric/Proj/rust/cargo/target/tmp/cit/t0/foo) note: Waiting for `delay@0.0.2` to be available at registry `crates-io`. You may press ctrl-c to skip waiting; the crate should be available shortly. Waiting [===> ] 11/60 Published delay v0.0.2 (/Users/eric/Proj/rust/cargo/target/tmp/cit/t0/foo) has been successfully published to registry `crates-io` ``` (Note: In the last two cases the progress bar disappears when it is done, I have just included it here to illustrate.) Fixes #11304
Problem
This is split out of #11062
When we poll for the crate having been published, it reports "Updating index" for each iteration
Steps
With the latest cargo, publish a crate
Possible Solution(s)
Temporarily turn on quiet in the code
Notes
No response
Version
No response
The text was updated successfully, but these errors were encountered: