Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keyword limitations are not apparent #2098

Closed
WaDelma opened this issue Oct 31, 2015 · 2 comments
Closed

Keyword limitations are not apparent #2098

WaDelma opened this issue Oct 31, 2015 · 2 comments
Labels
A-diagnostics Area: Error and warning messages generated by Cargo itself.

Comments

@WaDelma
Copy link

WaDelma commented Oct 31, 2015

There is no information in cargo's manifest information about the limitations on keywords.
I tried to add keyword "object distribution" and "blue noise" to my crate and when I tried to publish it, it complained:

api errors: invalid upload request: ApplicationError("invalid keyword specified: object distribution")

With no information what was wrong (though I was able to guess that it was the space in the keyword).
There seems to be #1736 that touches on the problem, but from different angle.
There should be clearer indication on what is and what is not valid for Cargo.toml to contain.
And the limitation of not having space on keyword seems overly restrictive: While using separate tags for "object" and "distribution" seem fine, using separate tags for "blue" and "noise" seems silly and bad.

@alexcrichton alexcrichton added the A-diagnostics Area: Error and warning messages generated by Cargo itself. label Nov 1, 2015
@joshtriplett
Copy link
Member

Similarly, cargo should warn about having too many keywords; crates.io has a maximum of 5.

@weihanglo
Copy link
Member

Triage: This looks like an duplicate of #4300, and #4377 tracks some more validation people are interested in. Closing in favor of those.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-diagnostics Area: Error and warning messages generated by Cargo itself.
Projects
None yet
Development

No branches or pull requests

4 participants